Skip to content

[7.x] [Snapshot + Restore] Set snapshots response size limit (#103331) #103693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2021
Merged

[7.x] [Snapshot + Restore] Set snapshots response size limit (#103331) #103693

merged 4 commits into from
Jun 30, 2021

Conversation

@alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Jun 29, 2021

Backports the following commits to 7.x:

@alisonelizabeth
[Snapshot + Restore] Set snapshots response size limit (elastic#103331)
208e463 
# Conflicts:
#	x-pack/plugins/snapshot_restore/server/routes/api/repositories.test.ts
#	x-pack/plugins/snapshot_restore/server/routes/api/repositories.ts
#	x-pack/plugins/snapshot_restore/server/routes/api/snapshots.test.ts
#	x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts
@alisonelizabeth alisonelizabeth added the backport This PR is a backport of another PR label Jun 29, 2021
@alisonelizabeth alisonelizabeth enabled auto-merge (squash) June 29, 2021 15:37
@alisonelizabeth
Copy link
Contributor Author

alisonelizabeth commented Jun 29, 2021 •
edited
Loading

Note: I'm temporarily skipping a functional test via 4fd6182 in order to get CI passing. The ES changes associated with this are not yet available via snapshot. I have tested manually using yarn es source to verify the UI is still working as expected.

Related ES backport PR: elastic/elasticsearch#74676

@alisonelizabeth
Copy link
Contributor Author

alisonelizabeth commented Jun 29, 2021

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

alisonelizabeth commented Jun 30, 2021

Rerunning CI due to elasticsearch-ci/docs check hanging.

@alisonelizabeth alisonelizabeth mentioned this pull request Jun 30, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 30, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 460.2KB 461.6KB +1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 417.8KB 417.9KB +55.0B
snapshotRestore 41.1KB 41.2KB +118.0B
total +173.0B
Unknown metric groups

API count

id before after diff
snapshotRestore 22 23 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 969de56 into elastic:7.x Jun 30, 2021
@alisonelizabeth alisonelizabeth deleted the backport/7.x/pr-103331 branch June 30, 2021 01:54
@alisonelizabeth alisonelizabeth mentioned this pull request Jun 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alisonelizabeth @kibanamachine