Skip to content

Conversation

@ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 8, 2020

For now, the packages have old and new fields inside. As soon as Kibana and Agent are shipped, the old definition can be removed. See also elastic/package-storage#56

ruflin added 2 commits June 8, 2020 15:57
For now, the packages have old and new fields inside. As soon as Kibana and Agent are shipped, the old definition can be removed. See also elastic/package-storage#56
@ruflin ruflin requested a review from mtojek June 8, 2020 14:01
@ruflin ruflin self-assigned this Jun 8, 2020
@ruflin
Copy link
Contributor Author

ruflin commented Jun 8, 2020

@mtojek For the dashboards I did a find / replace. I wonder if this catches all the occurences.

@mtojek
Copy link
Contributor

mtojek commented Jun 8, 2020

Reviewing

@elasticmachine
Copy link

elasticmachine commented Jun 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #64 updated]

  • Start Time: 2020-06-09T14:08:15.301+0000

  • Duration: 3 min 54 sec

@mtojek
Copy link
Contributor

mtojek commented Jun 8, 2020

A couple of observations:

  1. Do you think we can remove stream.* fields now? No dashboard or ingest pipeline will be using them. Maybe we can limit number of pushes to integrations and package-storage repository if the agent supports temporarily both.
  2. Thanks for adjusting the dev/import-beats/fields_base_fields.go. I think there is small find & replace needed in kibana.go (import-beats).

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some observations.

@ruflin
Copy link
Contributor Author

ruflin commented Jun 9, 2020

I removed the stream.* fields now as the agent supports both at the moment. Also modified the kibana.go, please have a look again.

@mtojek mtojek self-requested a review June 9, 2020 13:49
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes in import-beats. If the CI goes green, feel free to merge.

@mtojek
Copy link
Contributor

mtojek commented Jun 9, 2020

[2020-06-09T13:51:49.975Z] 2020/06/09 13:51:49 validating required fields failed (datasetPath: /var/lib/jenkins/workspace/Beats_integrations_PR-64/src/github.com/elastic/integrations/build/public/package/aws/0.1.0/dataset/billing): finding field failed (searchedName: stream.type): field 'stream.type' not found

I think you need to bump up the dependency on the package-registry.

@mtojek mtojek self-requested a review June 9, 2020 13:54
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed.

@mtojek mtojek self-requested a review June 9, 2020 14:23
@ruflin ruflin merged commit 3feadf1 into elastic:master Jun 9, 2020
@ruflin ruflin deleted the update-dataset-in-packages branch June 9, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants