-
Notifications
You must be signed in to change notification settings - Fork 515
Update dataset in packages #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For now, the packages have old and new fields inside. As soon as Kibana and Agent are shipped, the old definition can be removed. See also elastic/package-storage#56
|
@mtojek For the dashboards I did a find / replace. I wonder if this catches all the occurences. |
|
Reviewing |
|
A couple of observations:
|
mtojek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some observations.
|
I removed the |
mtojek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changes in import-beats. If the CI goes green, feel free to merge.
|
I think you need to bump up the dependency on the package-registry. |
mtojek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed.
For now, the packages have old and new fields inside. As soon as Kibana and Agent are shipped, the old definition can be removed. See also elastic/package-storage#56