-
Notifications
You must be signed in to change notification settings - Fork 513
[azure logs] Add processor version options to Raw Events integration (v1) #15900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
|
||
| # Encoding extension | ||
| - rename: | ||
| field: body.structured |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this field renamed only for activity_logs? Should the body.structured needs to be renamed in other data streams like sign-in logs, graph_activity logs as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I included a couple of things that don't belong here 🤦 I'll clean up the commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muthu-mps, PR content fixed!
63f959e to
1bc4092
Compare
1bc4092 to
d5e9f6a
Compare
muthu-mps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmoog - changelog entry is missing, change looks good to me otherwise!
💚 Build Succeeded
History
cc @zmoog |
| # | ||
| # Processor v2 only settings | ||
| # | ||
| - name: processor_version | ||
| type: text | ||
| title: Processor version | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: v1 | ||
| description: "The processor version that the integration should use. Possible values are `v1` and `v2` (preview). \nThe v2 event hub processor is in preview, so using the v1 processor is recommended for typical use cases.\nDefault is `v1`." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # | |
| # Processor v2 only settings | |
| # | |
| - name: processor_version | |
| type: text | |
| title: Processor version | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: v1 | |
| description: "The processor version that the integration should use. Possible values are `v1` and `v2` (preview). \nThe v2 event hub processor is in preview, so using the v1 processor is recommended for typical use cases.\nDefault is `v1`." | |
| - name: processor_version | |
| type: text | |
| title: Processor version | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: v1 | |
| description: "The processor version that the integration should use. Possible values are `v1` and `v2` (preview). \nThe v2 event hub processor is in preview, so using the v1 processor is recommended for typical use cases.\nDefault is `v1`." | |
| # | |
| # Processor v2 only settings | |
| # |
| # | |
| # Processor v2 only settings | |
| # | |
| - name: processor_version | |
| type: text | |
| title: Processor version | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: v1 | |
| description: "The processor version that the integration should use. Possible values are `v1` and `v2` (preview). \nThe v2 event hub processor is in preview, so using the v1 processor is recommended for typical use cases.\nDefault is `v1`." | |
| # | |
| # Processor v2 only settings | |
| # | |
| - name: processor_version | |
| type: text | |
| title: Processor version | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: v1 | |
| description: "The processor version that the integration should use. Possible values are `v1` and `v2` (preview). \nThe v2 event hub processor is in preview, so using the v1 processor is recommended for typical use cases.\nDefault is `v1`." |
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Lets add a changelog and it's good to go!
Proposed commit message
Add the processor version option to the Raw Events integration v1. With these new options, users can switch from processor v1 (current default) to the processor v2.
This change anticipate the switch to v2 as default processor.
Checklist
changelog.ymlfile.I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
v2Screenshots