-
Notifications
You must be signed in to change notification settings - Fork 1.2k
update watcher examples for 7.x #333
Conversation
|
@gingerwizard if this gets merged the watches will no longer work for 5.x as I fixed all of the deprecation warnings. Also, can you have a look at the changes I made to run_test.py related to ingest pipelines? The test passes, but I am not clear on what the pipeline is doing. There were significant changes made to the Python libs. |
|
Merging as the examples are out of date and are people are being referred to them. I will setup some time when we are all back at work to review. These all pass the tests: |
|
👍 for your work as the tests were broken for ES 7. I will take a closer look at it. As a matter of fact, I already worked on ES 7 support in #239. Would you be interested in checking this PR out? For the last years I felt like no one cares about Watch testing. In case someone cares I will rebase onto your changes (master). |
|
@ypid-geberit Hi Robin, I will take a look. I am on vacation for a couple weeks, but I added it to my calendar for when I get back. I understand your frustration, I will try to look in this repo once in a while and help out with merging PRs. I wish I would have seen yours when I started working on my updates, from a quick look it looks like you had already figured many things out! |
No description provided.