-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Switch fleet's built-in ILM policies to use .actions.rollover.max_primary_shard_size #99984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kpollich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the Fleet side, but we'll need someone from ES to pick this up and handle changelog generation and any other checks on their end.
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@elasticmachine ok to test |
andreidan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming CI is happy), thanks for making this change
The automation failed to created a changelog for some reason, can you please create a quick entry under docs/changelog (there's an example here https://github.com/elastic/elasticsearch/blob/main/docs/changelog/98622.yaml )
|
OK, I added a changelog |
|
Do you have any idea why |
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
1 similar comment
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
|
@rodrigc can you please update this branch to get the latest changes from |
…mary_shard_size Fixes #99983 Signed-off-by: Craig Rodrigues <[email protected]>
|
Ok, I updated the branch |
Description
In the Kibana UI, when looking at ILM policies related to fleet, I see warnings:
Maximum index size is deprecated and will be removed in a future version. Use maximum primary shard size instead.. This comes from elastic/kibana#96545
To avoid confusion for the end-user, I recommend that the same changes which were done in elasticsearch's default ILM policies be done for fleet:
Related to:
Fixes #99983
Signed-off-by: Craig Rodrigues [email protected]