Skip to content

Conversation

@rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Sep 27, 2023

Description

In the Kibana UI, when looking at ILM policies related to fleet, I see warnings:

Maximum index size is deprecated and will be removed in a future version. Use maximum primary shard size instead.. This comes from elastic/kibana#96545

To avoid confusion for the end-user, I recommend that the same changes which were done in elasticsearch's default ILM policies be done for fleet:

Related to:

Fixes #99983

Signed-off-by: Craig Rodrigues [email protected]

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.11.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 27, 2023
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Fleet side, but we'll need someone from ES to pick this up and handle changelog generation and any other checks on their end.

@mattc58 mattc58 added Team:Data Management Meta label for data/management team :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 2, 2023
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@andreidan
Copy link
Contributor

@elasticmachine ok to test

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming CI is happy), thanks for making this change

The automation failed to created a changelog for some reason, can you please create a quick entry under docs/changelog (there's an example here https://github.com/elastic/elasticsearch/blob/main/docs/changelog/98622.yaml )

@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 4, 2023

OK, I added a changelog

@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 6, 2023

Do you have any idea why elasticsearch-ci/part-1 failed? I'm looking at the logs and can't figure out why this failed:

Build timed out (after 480 minutes). Marking the build as failed.
Build was aborted

@mattc58
Copy link
Contributor

mattc58 commented Oct 6, 2023

@elasticsearchmachine run elasticsearch-ci/part-1

1 similar comment
@mattc58
Copy link
Contributor

mattc58 commented Oct 6, 2023

@elasticsearchmachine run elasticsearch-ci/part-1

@mattc58
Copy link
Contributor

mattc58 commented Oct 6, 2023

@rodrigc can you please update this branch to get the latest changes from elastic:main? That may fix these build errors. Thanks!

@rodrigc
Copy link
Contributor Author

rodrigc commented Oct 7, 2023

Ok, I updated the branch

@mattc58 mattc58 merged commit 06e7127 into elastic:main Oct 7, 2023
@rodrigc rodrigc deleted the fleet-ilm-max-primary-shard-size branch October 7, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch fleet's built-in ILM policies to use .actions.rollover.max_primary_shard_size

5 participants