Skip to content

Fork response-sending in OpenPointInTimeAction #99222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fork response-sending in OpenPointInTimeAction #99222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df26535
Fork response-sending in OpenPointInTimeAction
DaveCTurner Sep 6, 2023
b256d5a
Update docs/changelog/99222.yaml
DaveCTurner Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/99222.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 99222
summary: Fork response-sending in `OpenPointInTimeAction`
area: Search
type: bug
issues: []
25 changes: 22 additions & 3 deletions server/src/main/java/org/elasticsearch/action/search/TransportOpenPointInTimeAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import org.elasticsearch.common.inject.Inject;
import org.elasticsearch.common.io.stream.StreamInput;
import org.elasticsearch.common.io.stream.StreamOutput;
import org.elasticsearch.common.util.concurrent.AtomicArray;
import org.elasticsearch.common.util.concurrent.AbstractRunnable;
import org.elasticsearch.core.TimeValue;
import org.elasticsearch.index.shard.ShardId;
import org.elasticsearch.search.SearchPhaseResult;
Expand Down Expand Up @@ -167,10 +167,29 @@ protected void executePhaseOnShard(
@Override
protected SearchPhase getNextPhase(SearchPhaseResults<SearchPhaseResult> results, SearchPhaseContext context) {
return new SearchPhase(getName()) {

private void onExecuteFailure(Exception e) {
onPhaseFailure(this, "sending response failed", e);
}

@Override
public void run() {
final AtomicArray<SearchPhaseResult> atomicArray = results.getAtomicArray();
sendSearchResponse(InternalSearchResponse.EMPTY_WITH_TOTAL_HITS, atomicArray);
execute(new AbstractRunnable() {
@Override
public void onFailure(Exception e) {
onExecuteFailure(e);
}

@Override
protected void doRun() {
sendSearchResponse(InternalSearchResponse.EMPTY_WITH_TOTAL_HITS, results.getAtomicArray());
}

@Override
public boolean isForceExecution() {
return true; // we already created the PIT, no sense in rejecting the task that sends the response.
}
});
}
};
}
Expand Down