ESQL: Standardize font used in railroad diagrams #98897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locks the railroad diagrams to always use the same font, this one named `roboto mono`. This makes sure that when we render the railroad diagrams we always size them the same way. Because everyone has a copy of roboto mono. Because gradle resolves that dependency.
Contributor
|
Documentation preview: |
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
Collaborator
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
Member
Author
|
The docs for this won't render correctly until we land a change to the docs build. I'll open a PR for that soon. |
Member
Author
|
This needs elastic/docs#2744 |
Member
Author
|
It's live: I'm glad that worked! I don't make many changes to the docs build stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locks the railroad diagrams to always use the same font, this one named
roboto mono. This makes sure that when we render the railroad diagrams we always size them the same way. Because everyone has a copy of roboto mono. Because gradle resolves that dependency.