[8.10] Abort downsample persistent task if source index disappeared during task re-assignment. (#98769) #98894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask re-assignment. (elastic#98769) The result of this issue is that a persistent gets stuck forever. The following errors can occur in the es log: ``` [2023-08-22T17:35:08,733][WARN ][o.e.c.s.ClusterApplierService] [node_t0] failed to notify ClusterStateListener 1> org.elasticsearch.index.IndexNotFoundException: no such index [avrcruawcg] 1> at org.elasticsearch.cluster.routing.RoutingTable.shardRoutingTable(RoutingTable.java:142) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.xpack.downsample.DownsampleShardPersistentTaskExecutor.getAssignment(DownsampleShardPersistentTaskExecutor.java:113) ~[main/:?] 1> at org.elasticsearch.xpack.downsample.DownsampleShardPersistentTaskExecutor.getAssignment(DownsampleShardPersistentTaskExecutor.java:51) ~[main/:?] 1> at org.elasticsearch.persistent.PersistentTasksClusterService.createAssignment(PersistentTasksClusterService.java:351) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.persistent.PersistentTasksClusterService.shouldReassignPersistentTasks(PersistentTasksClusterService.java:438) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.persistent.PersistentTasksClusterService.clusterChanged(PersistentTasksClusterService.java:366) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.cluster.service.ClusterApplierService.callClusterStateListener(ClusterApplierService.java:560) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.cluster.service.ClusterApplierService.callClusterStateListeners(ClusterApplierService.java:546) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.cluster.service.ClusterApplierService.applyChanges(ClusterApplierService.java:505) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.cluster.service.ClusterApplierService.runTask(ClusterApplierService.java:429) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.cluster.service.ClusterApplierService$UpdateTask.run(ClusterApplierService.java:154) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:916) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:217) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:183) ~[elasticsearch-8.10.0-SNAPSHOT.jar:8.10.0-SNAPSHOT] 1> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?] 1> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?] ``` This changes checks for this situation and allows these downsample tasks to fail and cleanup. This is done by assigning it to a data node, so that when the operation is executed on that node it fails and cleaned up. (because the index couldn't be found). Relates to elastic#98764 (marking as non issue, since this is bug in non released code)
martijnvg
added
:StorageEngine/Downsampling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.10: