Replace list of collectors with array in profile collector #95427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It simplifies things if we can just use an array to hold the children collectors in InternalProfileCollector, and adjust its constructor to take a varargs argument of collectors
javanna
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
iverase
approved these changes
Apr 20, 2023
Contributor
iverase
left a comment
iverase
left a comment
There was a problem hiding this comment.
LGTM. Just have a small doubt on null checks but it is a nice change.
server/src/main/java/org/elasticsearch/search/profile/query/InternalProfileCollector.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It simplifies things if we can just use an array to hold the children collectors in InternalProfileCollector, and adjust its constructor to take a varargs argument of collectors