Skip to content

Remove unused deprecation logger. #95290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2023
Merged

Remove unused deprecation logger. #95290

merged 3 commits into from
Apr 17, 2023

Conversation

@howardhuanghua
Copy link
Contributor

@howardhuanghua howardhuanghua commented Apr 17, 2023

It's introduced in #72155.
And also the target logger class RestSearchAction is incorrect. So remove this unused deprecation logger directly.

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 17, 2023

@howardhuanghua please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v8.8.0 external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label labels Apr 17, 2023
@HiDAl HiDAl added >refactoring and removed needs:triage Requires assignment of a team area label labels Apr 17, 2023
@HiDAl
Copy link

HiDAl commented Apr 17, 2023

@elasticmachine test this please

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Apr 17, 2023
@HiDAl HiDAl added :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team and removed needs:triage Requires assignment of a team area label labels Apr 17, 2023
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 17, 2023

Pinging @elastic/es-search (Team:Search)

@HiDAl
Copy link

HiDAl commented Apr 17, 2023

hey @howardhuanghua please push a commit removing the changelog, since they are automatically created and in this case it's not necessary

@howardhuanghua
Copy link
Contributor Author

howardhuanghua commented Apr 17, 2023

Done. ^^

dnhatn
dnhatn approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @howardhuanghua.

@dnhatn dnhatn self-assigned this Apr 17, 2023
@dnhatn dnhatn merged commit 8d7c5a4 into elastic:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees

@dnhatn dnhatn

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@howardhuanghua @elasticsearchmachine @HiDAl @dnhatn