Skip to content

Conversation

@HiDAl
Copy link

@HiDAl HiDAl commented Apr 13, 2023

No description provided.

@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.8.0 needs:triage Requires assignment of a team area label labels Apr 13, 2023
@HiDAl HiDAl added >docs General docs changes Team:Data Management Meta label for data/management team :Data Management/Health and removed needs:triage Requires assignment of a team area label labels Apr 13, 2023
@HiDAl HiDAl requested review from andreidan and dakrone April 13, 2023 07:52
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Apr 13, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments, but otherwise looks good to me, thanks Pablo!

@HiDAl
Copy link
Author

HiDAl commented Apr 17, 2023

Thanks @dakrone !

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Pablo.

This generally looks good but it's missing the ESS/On prem widget (the ESS one describes how to get to dev tools etc)
This is how this PR guide currently displays https://elasticsearch_95208.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/troubleshoot-shards-capacity-issues.html

And this is what we're aiming for https://elasticsearch_95208.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/add-tier.html

@HiDAl
Copy link
Author

HiDAl commented Apr 17, 2023

@andreidan I though we do this only in the case there's a UI to modify these settings. Will update the PR tomorrow. thanks

@andreidan
Copy link
Contributor

andreidan commented Apr 17, 2023

@HiDAl We do for all cases as the ESS tab was instructions on how to get to Dev tools (or in some cases where support is available, to the dedicated UI).
e.g. https://elasticsearch_95208.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/increase-shard-limit.html

@HiDAl
Copy link
Author

HiDAl commented Apr 18, 2023

@andreidan I have added tabs for ESS and OnPrem. Thanks for the support here!

@HiDAl HiDAl requested a review from andreidan April 18, 2023 08:46
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this Pablo.

This looks great. Only one step to add in the guides and this is ready.

Thanks for working on this

[role="screenshot"]
image::images/kibana-console.png[{kib} Console,align="center"]

. Update the <<cluster-max-shards-per-node,`cluster.max_shards_per_node`>> setting:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in all cases we should as a first step inspect the current value of the setting.
Either via the GET _cluster/settings API or via the _health_report/shards_capacity API.

But let's please display that step and indicate that we need to increase the value of the setting relative to what's currently configured - here's an example of how we indicate this for a cluster setting https://elasticsearch_95208.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/increase-cluster-shard-limit.html

@HiDAl HiDAl requested a review from andreidan April 18, 2023 13:49
@HiDAl
Copy link
Author

HiDAl commented Apr 18, 2023

Finally! @andreidan I added the missing step! thanks for your review

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this Pablo

🚀 LGTM

@HiDAl HiDAl merged commit 253fe63 into elastic:main Apr 19, 2023
@HiDAl HiDAl deleted the shards-capacity-troubleshooting-guide branch April 19, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Health >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants