Destringify APM tracer interface #94864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today the APM `Tracer` interface identifies each span by a raw string, but in practice there is structure to these strings: task-related spans have IDs like `task-NNNN` and spans that relate to REST requests have IDs like `rest-NNNN`. This convention is distributed across the codebase a little too widely, so with this commit we centralise it into a `SpanId` class, and introduce specific overrides for `Task` and `RestRequest` to avoid callers needing to construct IDs themselves.
DaveCTurner
added
>non-issue
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/packaging-tests-windows-sample |
rjernst
approved these changes
Mar 29, 2023
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
LGTM. I like this (potential) increase in future consistency.
Contributor
Author
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the APM
Tracerinterface identifies each span by a raw string, but in practice there is structure to these strings: task-related spans have IDs liketask-NNNNand spans that relate to REST requests have IDs likerest-NNNN. This convention is distributed across the codebase a little too widely, so with this commit we centralise it into aSpanIdclass, and introduce specific overrides forTaskandRestRequestto avoid callers needing to construct IDs themselves.