Enable _terms_enum on ip fields
#94322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _terms_enum API currently does not support ip fields. However, type-ahead-like completion is useful for UI purposes. This change adds the ability to query `ip` fields via the _terms_enum API by leveraging the terms enumeration available when doc_values are enabled on the field, which is the default. In order to make prefix filtering fast, we internally create a fast prefix automaton from the user-supplied prefix that gets intersected with the shards terms enumeration, similar to what we do for keyword fields already. Closes elastic#89933
cbuescher
added
>enhancement
:Search Foundations/Mapping
Contributor
|
Documentation preview: |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @cbuescher, I've created a changelog YAML for you. |
Member
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Member
Author
|
@romseygeek thanks a lot for reviewing |
Member
Author
|
Just out of curiosity and for documentation purposes: I was interested in the average size of the prefix automata this creates for small prefix sizes (1-7 characters seems common enough). Since the automaton lets you see the number of states, transitions and estimated size in bytes I did a few very limited experiments (1000 random Ips, prefix length random between 1-7 chars) and got the following rough estimates: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _terms_enum API currently does not support ip fields. However,
type-ahead-like completion is useful for UI purposes.
This change adds the ability to query
ipfields via the _terms_enum API byleveraging the terms enumeration available when doc_values are enabled on the
field, which is the default. In order to make prefix filtering fast, we
internally create a fast prefix automaton from the user-supplied prefix that
gets intersected with the shards terms enumeration, similar to what we do for
keyword fields already.
Closes #89933