Set time series feature flag for tests in aggregation module #91507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set time series feature flag for release builds to test and internalClusterTest tasks. So that the time series aggregation test doesn't fail, because the plugin wouldn't load the time_series aggregation. Closes elastic#91505
martijnvg
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Nov 10, 2022
|
|
||
| if (BuildParams.isSnapshotBuild() == false) { | ||
| tasks.named("test").configure { | ||
| systemProperty 'es.index_mode_feature_flag_registered', 'true' |
Member
There was a problem hiding this comment.
There's a nice thing for this now!
requiresFeature 'es.index_mode_feature_flag_registered', Version.fromString("8.0.0")
Member
Author
There was a problem hiding this comment.
I tried to use it, but I think that is only possible inside a testClusters definition? Which is only for rest based tests?
Member
Author
There was a problem hiding this comment.
I've merged this PR now, so that the release tests stop failing.
If requiresFeature can also be used here then I can change that in a follow up PR.
Member
Author
|
+1
…On Thu, Nov 10, 2022 at 4:24 PM Nik Everett ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In modules/aggregations/build.gradle
<#91507 (comment)>
:
> @@ -27,6 +28,15 @@ restResources {
}
}
+if (BuildParams.isSnapshotBuild() == false) {
+ tasks.named("test").configure {
+ systemProperty 'es.index_mode_feature_flag_registered', 'true'
There's a nice thing for this now!
requiresFeature 'es.index_mode_feature_flag_registered', Version.fromString("8.0.0")
—
Reply to this email directly, view it on GitHub
<#91507 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENWRMETOIJSSVHXC3LDOTWHUHRJANCNFSM6AAAAAAR4R2DEE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set time series feature flag for release builds to test and internalClusterTest tasks. So that the time series aggregation test doesn't fail, because the plugin wouldn't load the time_series aggregation.
Closes #91505