Skip to content

Conversation

@emilioalvap
Copy link
Contributor

Summary

Add read synthetics-* privilege for elastic/fleet-server service account as per this requirement: elastic/beats#33299

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Documentation preview:

@emilioalvap emilioalvap added the Team:Security Meta label for security team label Nov 8, 2022
@elasticsearchmachine elasticsearchmachine added v8.6.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team and removed Team:Security Meta label for security team labels Nov 8, 2022
@jakelandis jakelandis added >enhancement :Security/Security Security issues without another label and removed needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 8, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Nov 8, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@jakelandis
Copy link
Contributor

It looks like the test failure is related, can you take a look ?

To reproduce: ./gradlew ':x-pack:plugin:security:test' --tests "org.elasticsearch.xpack.security.authc.service.ElasticServiceAccountsTests.testElasticFleetServerPrivileges"

@emilioalvap
Copy link
Contributor Author

@jakelandis Done, thanks for the headsup

@jakelandis
Copy link
Contributor

@joshdover - are you good with this change ?

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilioalvap
Copy link
Contributor Author

@jakelandis Fleet team has given their approval via @juliaElastic, can we proceed to merge this one in?

@jakelandis jakelandis merged commit 9f22838 into elastic:main Nov 14, 2022
@jakelandis
Copy link
Contributor

@emilioalvap - I merged the change and will now be part of the 8.6 release. LMK if you need you need to back port this to other releases.

@emilioalvap
Copy link
Contributor Author

@jakelandis Thanks! can we backport this to 8.5 too? It's linked to a PR on the beats repo that has also been backported

ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Nov 15, 2022
Add read synthetics-* privilege for elastic/fleet-server service account.

related: elastic/beats#33299
@ywangd
Copy link
Member

ywangd commented Nov 15, 2022

I raised a backport PR to 8.5 #91572

elasticsearchmachine pushed a commit that referenced this pull request Nov 15, 2022
Add read synthetics-* privilege for elastic/fleet-server service account.

related: elastic/beats#33299

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Nov 15, 2022
* main: (163 commits)
  [DOCS] Edits frequent items aggregation (elastic#91564)
  Handle providers of optional services in ubermodule classloader (elastic#91217)
  Add `exportDockerImages` lifecycle task for exporting docker tarballs (elastic#91571)
  Fix CSV dependency report output file location in DRA CI job
  Fix variable placeholder for Strings.format calls (elastic#91531)
  Fix output dir creation in ConcatFileTask (elastic#91568)
  Fix declaration of dependencies in DRA snapshots CI job (elastic#91569)
  Upgrade Gradle Enterprise plugin to 3.11.4 (elastic#91435)
  Ingest DateProcessor (small) speedup, optimize collections code in DateFormatter.forPattern (elastic#91521)
  Fix inter project handling of generateDependenciesReport (elastic#91555)
  [Synthetics] Add synthetics-* read to fleet-server (elastic#91391)
  [ML] Copy more settings when creating DF analytics destination index (elastic#91546)
  Reduce CartesianCentroidIT flakiness (elastic#91553)
  Propagate last node to reinitialized routing tables (elastic#91549)
  Forecast write load during rollovers (elastic#91425)
  [DOCS] Warn about potential overhead of named queries (elastic#91512)
  Datastream unavailable exception metadata (elastic#91461)
  Generate docker images and dependency report in DRA ci job (elastic#91545)
  Support cartesian_bounds aggregation on point and shape (elastic#91298)
  Add support for EQL samples queries (elastic#91312)
  ...

# Conflicts:
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Security/Security Security issues without another label Team:Security Meta label for security team v8.5.2 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants