Move time_series aggregation to aggregations module. #91356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also drops the TimeSeries ceremonial interface. Note that this change also moves a search cancellation test to aggregations module. It does so by creating a base search cancallation base class that both server and this module share. Relates to elastic#90283 Relates to elastic#82273
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
60 tasks
nik9000
approved these changes
Nov 8, 2022
| protected Collection<Class<? extends Plugin>> nodePlugins() { | ||
| List<Class<? extends Plugin>> plugins = new ArrayList<>(super.nodePlugins()); | ||
| plugins.add(AggregationsPlugin.class); | ||
| return List.copyOf(plugins); |
Member
There was a problem hiding this comment.
probably fine to just return plugins?
Member
Author
There was a problem hiding this comment.
This test also needs a plugin from the super class. This is the test plugin that allows for testing the cancellation.
…ggregations_module
martijnvg
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also drops the TimeSeries ceremonial interface.
Note that this change also moves a search cancellation test to aggregations module. It does so by creating a base search cancallation base class that both server and this module share.
Relates to #90283
Relates to #82273