[8.5] Fix TransportResponse reference counting in DirectResponseChannel (#91289) #91315
+132
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…astic#91289) In elastic#76474 we fixed a circuit breaker leak in TransportActionProxy by incrementing a reference on the TransportResponse that is later decremented by the OutboundHandler. This works well for all cases except when the request targets the node which is also the proxy node. In that case the reference is incremented but will never be decremented as the local execution (using TransportService#localNodeConnection and DirectResponseChannel) bypasses the OutboundHandler. This change fixes the ref counting by also decrementing the TransportResponse in DirectResponseChannel. This will also have the consequence to correctly decrement used bytes of the request circuit breaker when GetCcrRestoreFileChunkResponse are executed on a node that is also a proxy node.
tlrx
added
:Distributed Coordination/Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.5: