Remove the deprecated Authentication#getVersion method #91067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the deprecated Authentication#getVersion method and replaces its usages by #getEffectiveSubject#getVersion.
ywangd
added
>refactoring
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
n1v0lg
approved these changes
Oct 24, 2022
| * | ||
| * Authentication is serialized and travels across the cluster nodes as the sub-requests are handled, | ||
| * and can also be cached by long-running jobs that continue to act on behalf of the user, beyond | ||
| * the lifetime of the original request. |
Contributor
There was a problem hiding this comment.
Optional: could make sense to add a note along the lines of "Use getEffectiveSubject().getVersion() to retrieve the version of an authentication instance." to the Javadoc.
Member
Author
There was a problem hiding this comment.
It would be helpful to add some more comments in the javadoc for the Authenticaton to explain its current structure and how it should be reasoned about. I'll make it in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated Authentication#getVersion method and replaces its usages by #getEffectiveSubject#getVersion.
Relates: #88494