Dry up TransportResponseHandler use via ActionListenerResponseHandler #90926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the action listener response handler in a couple additional spots to get proper `toString` that make slow logging easier to interpret if needed and to save some LoC and duplication.
original-brownbear
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
| public class ActionListenerResponseHandler<Response extends TransportResponse> implements TransportResponseHandler<Response> { | ||
|
|
||
| private final ActionListener<? super Response> listener; | ||
| protected final ActionListener<? super Response> listener; |
Contributor
There was a problem hiding this comment.
Is this change required? It looks like all of the updated usages are referencing the same listener that is passed in constructor or am I missing something?
Contributor
Author
There was a problem hiding this comment.
This way we save a reference in some, because we don't have to capture listener twice (once in the variable and once in the anonymous capture). We have the same approach in ActionRunnable so I did it here also to save some references (if only to make heap dumps easier to grind through :D).
idegtiarenko
approved these changes
Oct 18, 2022
Contributor
idegtiarenko
left a comment
idegtiarenko
left a comment
There was a problem hiding this comment.
Left a comment, otherwise LGTM
Contributor
Author
|
Thanks Ievgen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the action listener response handler in a couple additional spots to get proper
toStringthat make slow logging easier to interpret if needed and to save some LoC and duplication.