Fix path to compatible x-pack tests #90925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelandis
changed the title
Contributor
Author
|
Semi related: #90929 . Here we are fixing the sourcing tests from |
elasticsearchmachine
added
the
needs:triage
jakelandis
added
>non-issue
and removed
needs:triage
elasticsearchmachine
added
the
needs:triage
jakelandis
added
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
nik9000
changed the title
nik9000
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatible REST tests (like normal REST tests) allow copying the tests from either
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test(includeCore) orx-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test(includeXpack). Both are currently broken. #90851 fixes the former , and this commit fixes the later. The fix here is to ensure the correct path to the x-pack rest tests when pulling from the elder branch for compatible testing. This only impacts modules that have the compatibility plugin enabled and are configured to pull from the main x-pack set of tests. Currently, this should only impact:x-pack:plugin:enrich:qa:restbut will fix it for future projects with that configuration.