Test fix: make DataStreamIT not sensitive to midnight (#90595) #90910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>test
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
approved these changes
Oct 14, 2022
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing these Mary
| assertThat(dataStream.getIndices().get(0).getName(), backingIndexEqualTo("metrics-foo", 1)); | ||
|
|
||
| String backingIndex = DataStream.getDefaultBackingIndexName("metrics-bar", 1); | ||
| DataStream barDataStream = getDataStreamResponse.getDataStreams().get(0).getDataStream(); |
Contributor
Author
There was a problem hiding this comment.
Haha, you are laughing but when I was first reading it I could swear foo was before bar :p. I had to reread it.
Collaborator
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
DataStreamITwere usingDataStream::getDefaultBackingIndexNameto determine the name of the backing index of a data stream. SinceDataStream::getDefaultBackingIndexNameis time sensitive (it uses the day in the index name), if the tests are executed around midnight there is a chance that the tests will fail.To fix that, we took the following steps:
backingIndexEqualToto verify if the name of the index is the expected one by checking the data stream name and the generation but not the day.Closes: #90595