Fix true/false accumulation bug in boolean source fallback #90895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>bug
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jdconrad
removed
the
auto-backport
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Oct 17, 2022
…0895) The SourceValueFetcherSortedBooleanDocValues previously accumulated true/false value totals without resetting between documents. This means that any counts on the same segment would continue to increase true/false value totals over multiple documents. This change fixes that bug by resetting true/false value totals per document.
jdconrad
added a commit
that referenced
this pull request
Oct 17, 2022
…90959) The SourceValueFetcherSortedBooleanDocValues previously accumulated true/false value totals without resetting between documents. This means that any counts on the same segment would continue to increase true/false value totals over multiple documents. This change fixes that bug by resetting true/false value totals per document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SourceValueFetcherSortedBooleanDocValuespreviously accumulated true/false value totals without resetting between documents. This means that any counts on the same segment would continue to increase true/false value totals over multiple documents. This change fixes that bug by resetting true/false value totals per document.