Ensure cleanups succeed in JoinValidationService #90601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we sort of assume that cleanups succeed in the `JoinValidationService`. A failure in these places might explain the leaks seen in elastic#90576 and elastic#89712. It's not obvious that anything can fail here but let's make sure.
DaveCTurner
added
>test
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
thecoop
reviewed
Oct 6, 2022
server/src/main/java/org/elasticsearch/cluster/coordination/JoinValidationService.java
Outdated
Show resolved
Hide resolved
thecoop
approved these changes
Nov 2, 2022
Member
thecoop
left a comment
thecoop
left a comment
There was a problem hiding this comment.
LGTM!
(however, I notice this is Distributed, rather than Core/Infra, but the change is simple enough)
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2022-10-03-JoinValidationService-ensure-cleanup-success
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 2, 2022
Today we sort of assume that cleanups succeed in the `JoinValidationService`. A failure in these places might explain the leaks seen in elastic#90576 and elastic#89712. It's not obvious that anything can fail here but let's make sure.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 2, 2022
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Nov 3, 2022
* main: (1300 commits) update c2id/c2id-server-demo docker image to support ARM (elastic#91144) Allow legacy index settings on legacy indices (elastic#90264) Skip prevoting if single-node discovery (elastic#91255) Chunked encoding for snapshot status API (elastic#90801) Allow different decay values depending on the score function (elastic#91195) Fix handling indexed envelopes crossing the dateline in mvt API (elastic#91105) Ensure cleanups succeed in JoinValidationService (elastic#90601) Add overflow behaviour test for RecyclerBytesStreamOutput (elastic#90638) More actionable error for ancient indices (elastic#91243) Fix APM configuration file delete (elastic#91058) Clean up handshake test class (elastic#90966) Improve H3#hexRing logic and add H3#areNeighborCells method (elastic#91140) Restrict direct use of `ApplicationPrivilege` constructor (elastic#91176) [ML] Allow NLP truncate option to be updated when span is set (elastic#91224) Support multi-intersection for FieldPermissions (elastic#91169) Support intersecting multi-sets of queries with DocumentPermissions (elastic#91151) Ensure TermsEnum action works correctly with API keys (elastic#91170) Fix NPE in auditing authenticationSuccess for non-existing run-as user (elastic#91171) Ensure PKI's delegated_by_realm metadata respect run-as (elastic#91173) [ML] Update API documentation for anomaly score explanation (elastic#91177) ... # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackClientPlugin.java # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/RollupShardIndexer.java # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/downsample/TransportRollupIndexerAction.java # x-pack/plugin/rollup/src/test/java/org/elasticsearch/xpack/rollup/v2/RollupActionSingleNodeTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we sort of assume that cleanups succeed in the
JoinValidationService. A failure in these places might explain the leaks seen in #90576 and #89712. It's not obvious that anything can fail here but let's make sure.