ignore_unavailable shouldn't ignore closed indices

[martijnvg]

The ignore_unavailable request setting shouldn't ignore closed indices if a single index is specified in a search or broadcast request.

PR for #7153

[javanna]

why?

[javanna]

can you remind me why we need this check again? Didn't we do it at the beginning of the method already? Maybe this if was a leftover?

[martijnvg]

because the index the alias is pointing to may be in a closed state.

[javanna]

I think we can remove this if completely, cause we call the same method given the same input at the beginning of the method, this condition will never be true here.

[javanna]

Actually, I did some digging, this if was introduced with #6475, and I think its purpose was to check that state of indices after aliases resolution. This is a bug that we should address on a separate issue, that should be about index state checks when resolving aliases, since it seems we don't check that at all at this time.

[martijnvg]

agreed, lets open another issue for this.

[javanna]

I left a couple of minor comments @martijnvg . The one thing I am not sure about is that the PR addresses the case of closed indices, while the related issue might be referring to more usecases around the single index special case, like:

curl -XGET localhost:9200/index1/_search?ignore_unavailable=true

# fails if index1 is not there, although we said ignore_unavailable=true
{
  "error" : "IndexMissingException[[index1] missing]",
  "status" : 404
}

Is this something that we want to address as well?

[martijnvg]

@javanna I updated the PR, addressed the minor comments and added tests for the case a single index mentioned doesn't exist.

[javanna]

Thanks @mvg LGTM, the single missing index case I mentioned before was something I overlooked on my end, it works as expected already, so this PR addresses what it should addresses, sorry for the confusion ;)

[zde]

This contradicts http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/multi-index.html
I see no rationale for special handling of the single non-wildcard index case.