Skip to content

[Doc] Release notes for v8.4.3 #90443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 29, 2022
Merged

[Doc] Release notes for v8.4.3 #90443

merged 10 commits into from
Sep 29, 2022

Conversation

@slobodanadamovic
Copy link
Contributor

@slobodanadamovic slobodanadamovic commented Sep 28, 2022 •
edited
Loading

Generated release notes and added highlights for 8.4.3 release.

Note: Command ./gradlew generateReleaseNotes did not generate highlights (#90398) for this patch release, so I had to manually add them.

@slobodanadamovic slobodanadamovic added >docs General docs changes Team:Docs Meta label for docs team v8.4.3 labels Sep 28, 2022
@slobodanadamovic slobodanadamovic marked this pull request as ready for review September 28, 2022 07:40
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 28, 2022

Pinging @elastic/es-docs (Team:Docs)

@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Sep 28, 2022

Preview of the changes:
https://elasticsearch_90443.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/current/release-highlights.html
https://elasticsearch_90443.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/current/es-release-notes.html
https://elasticsearch_90443.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/current/release-notes-8.4.3.html

@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Sep 28, 2022

Coming section seem to be empty. Should I remove it?

image

@lockewritesdocs
Copy link
Contributor

lockewritesdocs commented Sep 28, 2022

Coming section seem to be empty. Should I remove it?

@slobodanadamovic, it's only meant to say "Coming in 8.4.3" because the release notes are note yet published. So, working as designed 😆

@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Sep 28, 2022

it's only meant to say "Coming in 8.4.3" because the release notes are note yet published. So, working as designed 😆

Thank you for the clarification 👍

lockewritesdocs
lockewritesdocs reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggested changes and opened PRs to update the changelog.yml files for affected issues.

@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Sep 28, 2022

@elasticmachine run elasticsearch-ci/docs

@lockewritesdocs
Copy link
Contributor

lockewritesdocs commented Sep 28, 2022

Hmm...the build is complaining of an invalid link, but I'm building locally and it's valid. Will troubleshoot.

@lockewritesdocs lockewritesdocs self-requested a review September 28, 2022 16:25
lockewritesdocs
lockewritesdocs approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖 Thanks @slobodanadamovic!

@lockewritesdocs
Copy link
Contributor

lockewritesdocs commented Sep 28, 2022

@slobodanadamovic, just an FYI that this PR will need to be forward-ported to both 8.5 and master. Let me know if you'd like me to handle that work or if you want to tackle it.

@lockewritesdocs
Copy link
Contributor

lockewritesdocs commented Sep 28, 2022

Let's hold off on merging this PR for a bit. The change introduced by #90302 might not have fixed the issue. The related issue, #89500, was reopened -- I pinged with @thecoop to ask if we should remove that fix from the release notes.

@slobodanadamovic
Copy link
Contributor Author

slobodanadamovic commented Sep 29, 2022 •
edited
Loading

Let's hold off on merging this PR for a bit. The change introduced by #90302 might not have fixed the issue.

Thanks Adam for spotting it. I will not merge yet.

@slobodanadamovic, just an FYI that this PR will need to be forward-ported to both 8.5 and master. Let me know if you'd like me to handle that work or if you want to tackle it.

If you have time, that would be nice. Thank you. 🙏

Note: I've regenerated notes after new BC was built. This included a new changes introduced by #90319. I'd appreciate if you could review this change as well.

@lockewritesdocs lockewritesdocs merged commit 25a196f into elastic:8.4 Sep 29, 2022
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 29, 2022

💔 Backport failed

The backport operation could not be completed due to the following error:

There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 90443

@lockewritesdocs lockewritesdocs mentioned this pull request Sep 29, 2022
Merged
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Sep 29, 2022
@slobodanadamovic
[Doc] Release notes for v8.4.3 (elastic#90443)
264dd41 
* Update docs for v8.4.3 release

* Update release highlights for 8.4.3 version.

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Make link external type

* Update release notes to include elastic#90319 PR after creating BC2.

* Remove release note for elastic#90302

* Minor grammar fix

Co-authored-by: Adam Locke <[email protected]>
(cherry picked from commit 25a196f)

# Conflicts:
#	docs/reference/release-notes.asciidoc
#	docs/reference/release-notes/highlights.asciidoc
@lockewritesdocs lockewritesdocs mentioned this pull request Sep 29, 2022
Merged
@lockewritesdocs
Copy link
Contributor

lockewritesdocs commented Sep 29, 2022

💚 All backports created successfully

Status Branch Result
✅ main
✅ 8.5

Questions ?

Please refer to the Backport tool documentation

lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Sep 29, 2022
@slobodanadamovic
[Doc] Release notes for v8.4.3 (elastic#90443)
54c2c83 
* Update docs for v8.4.3 release

* Update release highlights for 8.4.3 version.

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Make link external type

* Update release notes to include elastic#90319 PR after creating BC2.

* Remove release note for elastic#90302

* Minor grammar fix

Co-authored-by: Adam Locke <[email protected]>
(cherry picked from commit 25a196f)

# Conflicts:
#	docs/reference/release-notes.asciidoc
#	docs/reference/release-notes/highlights.asciidoc
@slobodanadamovic slobodanadamovic deleted the update-8-4-3-docs branch September 30, 2022 17:57
lockewritesdocs pushed a commit that referenced this pull request Sep 30, 2022
@slobodanadamovic
[Doc] Release notes for v8.4.3 (#90443) (#90539)
d9284db 
* Update docs for v8.4.3 release

* Update release highlights for 8.4.3 version.

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Make link external type

* Update release notes to include #90319 PR after creating BC2.

* Remove release note for #90302

* Minor grammar fix

Co-authored-by: Adam Locke <[email protected]>
(cherry picked from commit 25a196f)

# Conflicts:
#	docs/reference/release-notes.asciidoc
#	docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Slobodan Adamović <[email protected]>
lockewritesdocs pushed a commit that referenced this pull request Sep 30, 2022
@slobodanadamovic
[Doc] Release notes for v8.4.3 (#90443) (#90538)
52feb55 
* Update docs for v8.4.3 release

* Update release highlights for 8.4.3 version.

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/8.4.3.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Update docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Adam Locke <[email protected]>

* Make link external type

* Update release notes to include #90319 PR after creating BC2.

* Remove release note for #90302

* Minor grammar fix

Co-authored-by: Adam Locke <[email protected]>
(cherry picked from commit 25a196f)

# Conflicts:
#	docs/reference/release-notes.asciidoc
#	docs/reference/release-notes/highlights.asciidoc

Co-authored-by: Slobodan Adamović <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@debadair debadair Awaiting requested review from debadair

1 more reviewer

@lockewritesdocs lockewritesdocs lockewritesdocs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes Team:Docs Meta label for docs team v8.4.3 v8.4.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slobodanadamovic @elasticsearchmachine @lockewritesdocs