Skip to content

Enable TRACE Logging for test and increase timeout (#88477) #89728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable TRACE Logging for test and increase timeout (#88477) #89728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d90569
Enable TRACE Logging for test and increase timeout (#88477)
pxsalehi Jul 12, 2022
bd3ba2a
Merge branch '8.3' into ps-220830-cpick-GatewayMetaStateTest-timeout
elasticmachine Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions server/src/test/java/org/elasticsearch/gateway/GatewayMetaStatePersistedStateTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.elasticsearch.env.TestEnvironment;
import org.elasticsearch.node.Node;
import org.elasticsearch.test.ESTestCase;
import org.elasticsearch.test.junit.annotations.TestIssueLogging;
import org.elasticsearch.threadpool.TestThreadPool;
import org.elasticsearch.threadpool.ThreadPool;
import org.elasticsearch.transport.TransportService;
Expand Down Expand Up @@ -378,6 +379,7 @@ public void testStatePersistedOnLoad() throws IOException {
}
}

@TestIssueLogging(value = "org.elasticsearch.gateway:TRACE", issueUrl = "https://github.com/elastic/elasticsearch/issues/87952")
public void testDataOnlyNodePersistence() throws Exception {
final List<Closeable> cleanup = new ArrayList<>(2);

Expand Down Expand Up @@ -434,7 +436,7 @@ public void testDataOnlyNodePersistence() throws Exception {
);
persistedState.setCurrentTerm(state.term());
persistedState.setLastAcceptedState(state);
assertBusy(() -> assertTrue(gateway.allPendingAsyncStatesWritten()));
assertBusy(() -> assertTrue(gateway.allPendingAsyncStatesWritten()), 30, TimeUnit.SECONDS);

assertThat(
persistedState.getLastAcceptedState().getLastAcceptedConfiguration(),
Expand All @@ -452,7 +454,7 @@ public void testDataOnlyNodePersistence() throws Exception {
);

persistedState.markLastAcceptedStateAsCommitted();
assertBusy(() -> assertTrue(gateway.allPendingAsyncStatesWritten()));
assertBusy(() -> assertTrue(gateway.allPendingAsyncStatesWritten()), 30, TimeUnit.SECONDS);

CoordinationMetadata expectedCoordinationMetadata = CoordinationMetadata.builder(coordinationMetadata)
.lastCommittedConfiguration(coordinationMetadata.getLastAcceptedConfiguration())
Expand Down Expand Up @@ -506,7 +508,7 @@ public void testDataOnlyNodePersistence() throws Exception {
assertTrue(wroteState); // must write it at least once
assertEquals(currentTerm, persistedState.getCurrentTerm());
assertClusterStateEqual(state, persistedState.getLastAcceptedState());
assertBusy(() -> assertTrue(gateway.allPendingAsyncStatesWritten()));
assertBusy(() -> assertTrue(gateway.allPendingAsyncStatesWritten()), 30, TimeUnit.SECONDS);

gateway.close();
assertTrue(cleanup.remove(gateway));
Expand Down