Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Aug 23, 2022

Adds more tests for the enrich processor around different index types.
Right now they all work fine (yay!) but this feels like a good amount of
paranoia.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.5.0 labels Aug 23, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Aug 23, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@nik9000 nik9000 mentioned this pull request Aug 23, 2022
50 tasks
Adds more tests for the enrich processor around different index types.
Right now they all work fine (yay!) but this feels like a good amount of
paranoia.
@dakrone
Copy link
Member

dakrone commented Aug 23, 2022

These are all missing a human-readable "name" for the test (the "Test that X does Y" sort of string under the initial ---), can we add those so people can see at a glance what the test is testing?

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding these Nik! I left one comment about adding a description string for the test

@nik9000
Copy link
Member Author

nik9000 commented Aug 23, 2022

These are all missing a human-readable "name" for the test (the "Test that X does Y" sort of string under the initial ---), can we add those so people can see at a glance what the test is testing?

I don't tend to include the words "test that" but I have pushed some more descriptive language. run was terrible.

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 23, 2022
@elasticsearchmachine elasticsearchmachine merged commit 5e797c3 into elastic:main Aug 23, 2022
@nik9000 nik9000 deleted the enrich_processor_tests branch August 23, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants