Add text field support in the Painless scripting fields API #89396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
javanna
approved these changes
Aug 17, 2022
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
LGTM I think that this change closes effectively the issue you linked. Thanks for working on this, it will make accessing text fields from a script much easier!
Contributor
Author
|
@javanna @romseygeek Thank you both for the review! |
This was referenced Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds access to mapped text fields via the Painless scripting fields API. The values returned from a text field via the scripting fields API always use source as described by (#81246). Access via the old-style through doc will still depend on field data, so there is no change and avoids bwc issues.