-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] add new trained model deployment cache clear API #89074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] add new trained model deployment cache clear API #89074
Conversation
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
This has quite a major merge clash with #88901. I'll take it over once #88901 is merged. elastic/ml-cpp#2376 slightly changed the results structure, so if this PR were merged first then there would be two PRs that require coordination between the C++ and Java side. But if #88901 is merged first and then this PR updated to match then there'll only be one. |
|
Looks good from an API perspective! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion about formatting, otherwise docs LGTM.
docs/reference/ml/trained-models/apis/clear-trained-model-deployment-cache.asciidoc
Show resolved
Hide resolved
…oyment-cache.asciidoc Co-authored-by: István Zoltán Szabó <[email protected]>
|
@elasticmachine update branch |
droberts195
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
This adds a new
_ml/trained_models/<model_id>/deployment/cache/_clearAPI. This will clear the inference cache on every node where the model is allocated.