[ML] Frequent Items: use a bitset for deduplication #88943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2022 14:42
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @hendrikmuhs, I've created a changelog YAML for you. |
benwtrent
reviewed
Jul 29, 2022
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
Those numbers look great! I like some of the refactors as well. Just some minor comments.
.../plugin/ml/src/main/java/org/elasticsearch/xpack/ml/aggs/frequentitemsets/ItemSetBitSet.java
Outdated
Show resolved
Hide resolved
.../plugin/ml/src/main/java/org/elasticsearch/xpack/ml/aggs/frequentitemsets/ItemSetBitSet.java
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/ml/aggs/frequentitemsets/FrequentItemSetCollector.java
Show resolved
Hide resolved
...ugin/ml/src/main/java/org/elasticsearch/xpack/ml/aggs/frequentitemsets/ItemSetTraverser.java
Outdated
Show resolved
Hide resolved
...in/ml/src/test/java/org/elasticsearch/xpack/ml/aggs/frequentitemsets/ItemSetBitSetTests.java
Show resolved
Hide resolved
added 2 commits
August 1, 2022 13:01
…icsearch into frequent-items-bitset3
benwtrent
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using bitsets instead of lists of longs item sets can be faster de-duplicated. A bit is set according to the order of top items (by count).
Notes: