Discard intermediate node results when a request is cancelled #88851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
DaveCTurner
approved these changes
Jul 27, 2022
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I'm not sure if we need to modify the changelog like this - we normally backport the changelog as-is. Still, LGTM, I'll raise the changelog question out-of-band.
Contributor
Author
|
Thanks @DaveCTurner. At first I also backported the changelog but then the CI created a new one, so I picked that one. I can check a few other backports to see what they have done, at least then I can be consistent. Please if you find something out let me know. |
Contributor
Author
|
I think this happened because I forgot to add the |
Contributor
|
Ah I see - you didn't have the |
This reverts commit d8c8f07.
gmarouli
added
the
auto-merge-without-approval
gmarouli
deleted the
backport-82685-discard-intermediate-results-on-cancellation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #82685