[ML] adjust internal inference object to accept request_id in outer object #88485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Jul 19, 2022
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM
Please hold of merging for now in case we have to format again - the back end change isn't as simple as I imagined
|
To make this most useful the cache hit indicator also needs to be on the top level. I'd also prefer to make the Java and C++ changes in parallel and mute tests during the few hours where they're out-of-sync. It will make the code history cleaner in the future if anyone wants to look back at what was changed. Since you're going to be on leave soon and this PR already has lots of merge conflicts I will close it and copy the relevant bits to a new PR in my fork, which can then get tested in combination with a C++ side PR in the C++ CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
request_idis effectively required for all messages sent to the native process, this bubbles up the request_id to the outer object.It is currently optional (until the native side is changed).
If an inner object has the request_id set, and the outer object does not, the outer object request ID is set to that inner one.