Skip to content

Conversation

@andreidan
Copy link
Contributor

This also fixes some doc typos "reponse" -> "response".

This also fixes some doc typos "reponse" -> "response".
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Jun 27, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@andreidan andreidan requested a review from gmarouli June 27, 2022 10:38
@andreidan
Copy link
Contributor Author

Failure tracked already in #88063

@andreidan
Copy link
Contributor Author

@elasticmachine update branch

// tag::self-managed[]
<<ilm-start, Start ILM>>:
<<ilm-start, Start Index Lifecycle Management>>:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why are we specifically typing here Index Lifecycle Management and not {ilm} like we do in the start-slm doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason. I think we can't link to these { } macros.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that's why in the slm it is <<ilm-start, Start>> {slm}. I would suggest to do the same here so we are consistently using the macros.

@pugnascotia pugnascotia added v8.3.2 and removed v8.3.1 labels Jun 29, 2022
@andreidan
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small suggestion about using a macro.

@andreidan andreidan merged commit 3e1242b into elastic:master Jun 30, 2022
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 88060

andreidan added a commit to andreidan/elasticsearch that referenced this pull request Jun 30, 2022
(cherry picked from commit 3e1242b)
Signed-off-by: Andrei Dan <[email protected]>
andreidan added a commit that referenced this pull request Jun 30, 2022
(cherry picked from commit 3e1242b)
Signed-off-by: Andrei Dan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Health >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v8.3.2 v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants