-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Brought back missing changelog for 87235 #87369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
craigtaverner
merged 1 commit into
elastic:master
from
craigtaverner:missing-changelog-87235
Jun 3, 2022
Merged
Brought back missing changelog for 87235 #87369
craigtaverner
merged 1 commit into
elastic:master
from
craigtaverner:missing-changelog-87235
Jun 3, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
f9e3ebb to
62e8fae
Compare
DaveCTurner
approved these changes
Jun 3, 2022
Contributor
DaveCTurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but note that this change should also be backported to 8.2 and 7.17 to match #87235.
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Jun 3, 2022
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Jun 3, 2022
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 3, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/CCR
Issues around the Cross Cluster State Replication features
>docs
General docs changes
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Team:Docs
Meta label for docs team
v7.17.5
v8.2.3
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the release notes for 8.3.0 it was discovered that there was a PR 87016 with a missing changelog.
Investigation showed that this PR was merged (with changelog), reverted and the merged again (as a new PR with no changelog). It is not clear why the second time around the changelog was not added.