Synthetic source: don't allow disabling source #87270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This rejects mappings that disable the `_source` but also configure it to be `synthetic` because that sort of configuration doesn't make sense - `synthetic` is a way to enable source at a low cost.
romseygeek
reviewed
Jun 6, 2022
| return DEFAULT; | ||
| } | ||
| if (enabled.getValue() == false && synthetic.getValue()) { | ||
| throw new IllegalArgumentException("_source may not be disabled when setting [synthetic: false]"); |
Contributor
There was a problem hiding this comment.
Shouldn't this be synthetic: true?
Member
Author
|
@romseygeek could you have another look at this one? |
Member
Author
|
Thanks @romseygeek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rejects mappings that disable the
_sourcebut also configure itto be
syntheticbecause that sort of configuration doesn't make sensesyntheticis a way to enable source at a low cost.