Skip to content

Conversation

@sethmlarson
Copy link
Contributor

This PR reverts #86517 which set the compatibility mode to always be enabled for the Java HLRC pending a deeper investigation into the impacts.

It looks like there were some documentation changes that could have been left but in the interest of getting a clean timely revert we'll go this route and add the documentation changes separately.

@elasticsearchmachine
Copy link
Collaborator

@sethmlarson please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 17, 2022
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label May 17, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@sethmlarson
Copy link
Contributor Author

Only one test is failing and it doesn't look relevant:

15:25:45 org.elasticsearch.packaging.test.ArchiveTests > test20PluginsListWithNoPlugins FAILED
15:25:45     java.lang.AssertionError: 
15:25:45     Expected: an empty string
15:25:45          but: was "warning: ignoring JAVA_TOOL_OPTIONS=-Dfile.encoding=UTF8 -Dsun.jnu.encoding=UTF8"
15:25:45         at __randomizedtesting.SeedInfo.seed([B7EB4B06A21B3B34:A3BFA7EE44067886]:0)
15:25:45         at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
15:25:45         at org.junit.Assert.assertThat(Assert.java:956)
15:25:45         at org.junit.Assert.assertThat(Assert.java:923)
15:25:45         at org.elasticsearch.packaging.test.ArchiveTests.test20PluginsListWithNoPlugins(ArchiveTests.java:60)

@sethmlarson
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

1 similar comment
@sethmlarson
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-tests-windows-sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Clients Meta label for clients team v7.17.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants