[7.17] Use TaskCancelledException in TMNA (#86659) #86669
Merged
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#72157 we made it so that cancelling the task that a `TransportMasterNodeAction` was executing causes the action to fail with a `java.util.concurrent.CancellationException`. This exception is treated as a `500 Internal Server Error` which results in `WARN`-level logs, but cancelling a task is normal and expected behaviour and should not be logged (see elastic#73524). This commit fixes this by using a `TaskCancelledException` instead, since this exception maps to a `400 Bad Request` and generates no logs.
DaveCTurner
added
:Distributed Coordination/Task Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.17: