User Profile - Use security origin for BWC cases #86345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The security profile action origin and internal user is not available before version 8.3.0. This PR makes all profile actions to use the existing security origin if the cluster has any node that is older than 8.3.0. The change makes it possible to use User Profile features in a mixed cluster as long as the request always hits a newer (newer than 8.3) node first.
ywangd
added
>non-issue
:Security/Security
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
ywangd
commented
May 3, 2022
Comment on lines
+6
to
+7
| version: " - 7.99.99" | ||
| reason: "https://github.com/elastic/elasticsearch/issues/86373" |
Member
Author
There was a problem hiding this comment.
The BWC test fails with 7.17 node because we assert that mappings must have a key of single-mapping-name (_doc) in 7.17 which is not always true in a mixed cluster. Since it is an AssertionError, it does not seem to be a problem in production. I raised #86373 to discuss whether we can just remove the assertions. In the meantime, I am muting the tests for 7.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The security profile action origin and internal user is not available
before version 8.3.0. This PR makes all profile actions to use the
existing security origin if the cluster has any node that is older than
8.3.0.
The change makes it possible to use User Profile features in a mixed
cluster (7.17 and 8.3+) as long as the request always hits a node of
newer version first.