Remove ImmutableOpen*Map from Version #86245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Version class has two internal static maps for keeping track of the known Version objects and quickly decoding from a version id into the known Version object. This commit converts these maps to HashMaps. relates elastic#86239
rjernst
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
original-brownbear
approved these changes
Apr 28, 2022
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM lets use the faster immutable map though?
| builderByString.put(V_EMPTY.toString(), V_EMPTY); | ||
| idToVersion = builder.build(); | ||
| stringToVersion = builderByString.build(); | ||
| idToVersion = Collections.unmodifiableMap(builder); |
Contributor
There was a problem hiding this comment.
Lets just do Map.copyOf for a smaller + faster map?
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Version class has two internal static maps for keeping track of the
known Version objects and quickly decoding from a version id into the
known Version object. This commit converts these maps to HashMaps.
relates #86239