Remove version skips for product header issue #86196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added some logic to skep checking the product header on versions with known bugs in the product header response functionality. Fortunately, we managed to get all of our fixes out in the same 8.x versions where we added the assertion, so we should be able to remove the 8.x skips altogether.
williamrandolph
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Member
|
LGTM. The 8.0.2 label can be removed, that branch is no longer maintained. |
1 similar comment
Member
|
LGTM. The 8.0.2 label can be removed, that branch is no longer maintained. |
rjernst
approved these changes
Apr 27, 2022
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Apr 27, 2022
We added some logic to skep checking the product header on versions with known bugs in the product header response functionality. Fortunately, we managed to get all of our fixes out in the same 8.x versions where we added the assertion, so we should be able to remove the 8.x skips altogether.
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Apr 27, 2022
We added some logic to skep checking the product header on versions with known bugs in the product header response functionality. Fortunately, we managed to get all of our fixes out in the same 8.x versions where we added the assertion, so we should be able to remove the 8.x skips altogether.
Collaborator
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 27, 2022
We added some logic to skep checking the product header on versions with known bugs in the product header response functionality. Fortunately, we managed to get all of our fixes out in the same 8.x versions where we added the assertion, so we should be able to remove the 8.x skips altogether.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 27, 2022
We added some logic to skep checking the product header on versions with known bugs in the product header response functionality. Fortunately, we managed to get all of our fixes out in the same 8.x versions where we added the assertion, so we should be able to remove the 8.x skips altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added some logic to skep checking the product header on versions with known bugs in the product header response functionality. Fortunately, we managed to get all of our fixes out in the same 8.x versions where we added the assertion, so we should be able to remove the 8.x skips altogether.
Closes #84243