Skip to content

[ML] Tests of the named writable registry for inference updates #85870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

[ML] Tests of the named writable registry for inference updates #85870

merged 1 commit into from
May 5, 2022

Conversation

@davidkyle
Copy link
Member

@davidkyle davidkyle commented Apr 13, 2022

Same motivation as #85867, different approach.

Related to #85863

@davidkyle davidkyle added :ml Machine learning v8.3.0 labels Apr 13, 2022
@davidkyle davidkyle requested a review from benwtrent April 13, 2022 12:42
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Apr 13, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 13, 2022

Pinging @elastic/ml-core (Team:ML)

@benwtrent benwtrent added the >test Issues or PRs that are addressing/adding tests label Apr 13, 2022
benwtrent
benwtrent approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooo! I like this. So clean. It will be good to include along side: #85867

One for a focused serialization to capture all updates, another to exercise the inference request objects.

@davidkyle
Copy link
Member Author

davidkyle commented Apr 13, 2022

@elasticmachine update branch

@davidkyle davidkyle merged commit ed43a3e into elastic:master May 5, 2022
@davidkyle davidkyle deleted the wrong-test branch May 5, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees

No one assigned

Labels

:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidkyle @elasticmachine @benwtrent