Log node identity at startup #85773
Merged
Log node identity at startup #85773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At startup we construct a `DiscoveryNode` which identifies the local node, and we report various components of this identity in the startup logs. You can often deduce other parts (e.g. the ephemeral and persistent node IDs) from other logs, but this is hard to do reliably. With this commit we report the node identity in full at startup to avoid any ambiguity. Relates elastic#83034, elastic#85721, and other test failures explainable by mistaken identities.
DaveCTurner
added
>enhancement
:Distributed Coordination/Network
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
idegtiarenko
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At startup we construct a
DiscoveryNodewhich identifies the localnode, and we report various components of this identity in the startup
logs. You can often deduce other parts (e.g. the ephemeral and
persistent node IDs) from other logs, but this is hard to do reliably.
With this commit we report the node identity in full at startup to avoid
any ambiguity.
Relates #83034, #85721, and other test failures explainable by mistaken
identities.