Skip to content

Conversation

@mayya-sharipova
Copy link
Contributor

No description provided.

@mayya-sharipova mayya-sharipova added the >docs General docs changes label Mar 31, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Mar 31, 2022
@mayya-sharipova mayya-sharipova added :Search/Search Search-related issues that do not fall into other categories and removed Team:Docs Meta label for docs team labels Mar 31, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Mar 31, 2022

Counting a number of documents that fall into a certain range could be faster now.
In {es} we use counting in aggregations (e.g. date range aggregation) and
for `_count` API.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iverase I am a little fuzzy how describe this change in PointRangeQuery . Can you please confirm this is a valid description.

@mayya-sharipova
Copy link
Contributor Author

Note, this changes doesn't include "LUCENE-10382: Support filtering in KnnVectorQuery", as we have a corresponding Elasticsearch PR that is marked as release highlight.

fields should see these improvements.

[discrete]
=== Faster "count" searches for Points
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The count search optimizations that were introduced do not apply to Elasticsearch until we start leveraging the new Weight#count API. However there are speedups for range queries indeed, maybe we could check the sort of improvement that we observed on nightly benchmarks to share a more catchy headline such as "Up to 20% faster range queries". For instance I'm looking at https://elasticsearch-benchmarks.elastic.co/index.html#tracks/noaa/nightly/default/90d where nightly-noaa-add-defaults-range_field_big_range-latency looks like it got a ~35% speedup on 2022-02-22.

Copy link
Contributor Author

@mayya-sharipova mayya-sharipova Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpountz Thanks for the suggestion. I will add this point and remove others.

Out of curiosity, which Lucene changes brought up these speedups in range queries? Are they applicable only for range fields or any Point fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in dc13f58, borrowing from your Lucene updates.

@mayya-sharipova
Copy link
Contributor Author

@jpountz Can you please have another look at this when you have time.

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jpountz
Copy link
Contributor

jpountz commented Apr 5, 2022

cc @giladgal

@mayya-sharipova mayya-sharipova merged commit 6254a71 into elastic:8.2 Apr 5, 2022
@mayya-sharipova mayya-sharipova deleted the lucene-highlights-9.1 branch April 5, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.2.0 v8.2.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants