Use cluster health API in validateClusterFormed #85454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elastic#76884 in `InternalTestCluster#validateClusterFormed` we wait for a correctly-sized cluster state to be applied before entering the `assertBusy()` loop to wait for the cluster state to be exactly right everywhere. Today we do this by injecting a cluster state observer into one of the nodes which waits for a cluster state containing a master and the right number of nodes. With this commit we move to using the cluster health API which can do the same thing. By this point any extra nodes have stopped, but there might still be a stale join request for one of those nodes in the master's queue. This commit addresses this by also waiting for the master queue to be empty. Closes elastic#81830
DaveCTurner
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
arteam
approved these changes
May 6, 2022
Contributor
arteam
left a comment
arteam
left a comment
There was a problem hiding this comment.
LGTM! This is a very neat internal usage of the Cluster Health API!
DaveCTurner
deleted the
2022-03-29-validateClusterFormed-await-empty-master-queue
branch
DaveCTurner
added a commit
that referenced
this pull request
May 6, 2022
Since #76884 in `InternalTestCluster#validateClusterFormed` we wait for a correctly-sized cluster state to be applied before entering the `assertBusy()` loop to wait for the cluster state to be exactly right everywhere. Today we do this by injecting a cluster state observer into one of the nodes which waits for a cluster state containing a master and the right number of nodes. With this commit we move to using the cluster health API which can do the same thing. By this point any extra nodes have stopped, but there might still be a stale join request for one of those nodes in the master's queue. This commit addresses this by also waiting for the master queue to be empty. Closes #81830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #76884 in
InternalTestCluster#validateClusterFormedwe wait fora correctly-sized cluster state to be applied before entering the
assertBusy()loop to wait for the cluster state to be exactly righteverywhere. Today we do this by injecting a cluster state observer into
one of the nodes which waits for a cluster state containing a master and
the right number of nodes. With this commit we move to using the cluster
health API which can do the same thing.
By this point any extra nodes have stopped, but there might still be a
stale join request for one of those nodes in the master's queue. This
commit addresses this by also waiting for the master queue to be empty.
Closes #81830