Assert actual follow tasks instead of count #85151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the test is flaky and sometimes fails with expected 1 but was 2 failure. Updating the code to assert against collection content to collect additional information on the cause of the failure.
idegtiarenko
added
>test-failure
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
commented
Mar 21, 2022
| followIndex(client(), "leader_cluster", allowedIndex, allowedIndex); | ||
| assertBusy(() -> verifyDocuments(allowedIndex, numDocs, "*:*")); | ||
| assertThat(countCcrNodeTasks(), equalTo(1)); | ||
| assertThat(getCcrNodeTasks(), contains(new CcrNodeTask("leader_cluster", allowedIndex, allowedIndex, 0))); |
Contributor
Author
There was a problem hiding this comment.
This assertion is currently failing with Expected: <1> but: was <2>.
I would like to know what is the extra element to be able to troubleshot this further, however this test is not reproducing locally. I am hoping this extra info will help to understand the source of the issue once the failure happens again.
idegtiarenko
added a commit
that referenced
this pull request
Mar 30, 2022
Currently, the test is flaky and sometimes fails with expected 1 but was 2 failure. Updating the code to assert against collection content to collect additional information on the cause of the failure. (cherry picked from commit e31be1b)
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Mar 30, 2022
Currently, the test is flaky and sometimes fails with expected 1 but was 2 failure. Updating the code to assert against collection content to collect additional information on the cause of the failure. (cherry picked from commit e31be1b)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 30, 2022
#85481) * Assert actual follow tasks instead of count (#85151) Currently, the test is flaky and sometimes fails with expected 1 but was 2 failure. Updating the code to assert against collection content to collect additional information on the cause of the failure. (cherry picked from commit e31be1b) * Ensure the cleanup in testAutoFollowPatterns is always happening (#85401) In case of failure testAutoFollowPatterns will leave auto-following pattern running that would case assertion failure in other test cases (cherry picked from commit 92c4538)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 30, 2022
…ng (#85482) * Assert actual follow tasks instead of count (#85151) Currently, the test is flaky and sometimes fails with expected 1 but was 2 failure. Updating the code to assert against collection content to collect additional information on the cause of the failure. (cherry picked from commit e31be1b) * Ensure the cleanup in testAutoFollowPatterns is always happening (#85401) In case of failure testAutoFollowPatterns will leave auto-following pattern running that would case assertion failure in other test cases (cherry picked from commit 92c4538) * revert java 17 usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the test is flaky and sometimes fails with expected 1 but was 2 failure.
Updating the code to assert against collection content to collect additional information on the cause of the failure.
Related to: #85147