[Transform] Introduce TransformScheduler central service #84657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
transform_pipeline
branch
2 times, most recently
from
7d3cc9e to
d374e9e
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
5 times, most recently
from
a799c76 to
4560772
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
from
4560772 to
dda2cc0
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
3 times, most recently
from
4376066 to
ab42380
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
2 times, most recently
from
cb2b596 to
be0171a
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
from
be0171a to
780a702
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
5 times, most recently
from
54fa083 to
8a0ec3c
Compare
Contributor
Author
|
run elasticsearch-ci/part-2 |
przemekwitek
force-pushed
the
transform_pipeline
branch
2 times, most recently
from
e7e109b to
f8c33a8
Compare
hendrikmuhs
reviewed
Jun 2, 2022
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
add some first round comments and questions
...form/src/main/java/org/elasticsearch/xpack/transform/transforms/ConcurrentPriorityQueue.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
davidkyle
reviewed
Jun 7, 2022
...form/src/main/java/org/elasticsearch/xpack/transform/transforms/ConcurrentPriorityQueue.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...form/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformSchedulerTests.java
Outdated
Show resolved
Hide resolved
...form/src/main/java/org/elasticsearch/xpack/transform/transforms/ConcurrentPriorityQueue.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
transform_pipeline
branch
2 times, most recently
from
cdf95fe to
9300a47
Compare
przemekwitek
force-pushed
the
transform_pipeline
branch
from
f322f28 to
e73dea6
Compare
benwtrent
reviewed
Jun 21, 2022
...rc/main/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduler.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
reviewed
Jun 23, 2022
...ava/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTaskQueue.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTaskQueue.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTaskQueue.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduler.java
Outdated
Show resolved
Hide resolved
davidkyle
reviewed
Jun 23, 2022
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
Looks good, I left some minor comments
...ain/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTask.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTask.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTaskQueue.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTaskQueue.java
Outdated
Show resolved
Hide resolved
...ava/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduledTaskQueue.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduler.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/transform/transforms/scheduling/TransformScheduler.java
Outdated
Show resolved
Hide resolved
Express the default frequency in seconds
przemekwitek
force-pushed
the
transform_pipeline
branch
from
f27336f to
7c705c1
Compare
hendrikmuhs
approved these changes
Jun 24, 2022
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
I have no further comments. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
TransformSchedulerclass as a central place for scheduling transform tasks. The outline of how this mechanism works is:next_scheduled_time_starta transform task is added to the queueschedulerFrequency(defaulting to5s) the first task is being picked up from the queue and processed, i.e.: its listener is being triggered (indirectly triggering the indexer)_stopa transform task is removed from the queue and no longer processednext_scheduled_timeis updated so that it is processed before it normally would. We are using exponential backoff scheme to calculate the appropriate delaysSchedulerEngineis no longer usedAdditionally, this PR implements unit tests for
TransformTaskParamsandTransformContextclasses.The following work items are not covered by this PR. These will be handled separately, in the subsequent PRs:
numFailureRetriesnumFailureRetriesRelates to #85016