Add a REST layer test for reverse_nested #83874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
elasticmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
69 tasks
REST layer tests are how we get backwards compatibility testing. So they are important! The `reverse_nested` aggregation doesn't have any configuration. Like, none. But it didn't have any REST tests at all which is a shame. This adds one.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 28, 2022
REST layer tests are how we get backwards compatibility testing. So they are important! The `reverse_nested` aggregation doesn't have any configuration. Like, none. But it didn't have any REST tests at all which is a shame. This adds one.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2022
REST layer tests are how we get backwards compatibility testing. So they are important! The `reverse_nested` aggregation doesn't have any configuration. Like, none. But it didn't have any REST tests at all which is a shame. This adds one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST layer tests are how we get backwards compatibility testing. So they
are important! The
reverse_nestedaggregation doesn't have anyconfiguration. Like, none. But it didn't have any REST tests at all
which is a shame. This adds one.