Document that awareness attributes override custom preferences #83818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting replicas in a search, the coordinating node prefers nodes with the same shard allocation awareness attributes. If the search contains a custom preference string, then it will be ignored in favor of selecting a node with the same attributes. In 8.0, allocation awareness attributes no longer influence search replica selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x. Instead, we document the behavior as a 'warning' and mention a system property that can be used to disable the behavior.
jtibshirani
added
>docs
elasticmachine
added
Team:Search
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
jrodewig
approved these changes
Feb 11, 2022
Contributor
jrodewig
left a comment
jrodewig
left a comment
There was a problem hiding this comment.
LGTM. I left a non-blocking wording suggestion that you can ignore if wanted.
docs/reference/search/search-your-data/search-shard-routing.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: James Rodewig <[email protected]>
jtibshirani
added a commit
that referenced
this pull request
Feb 14, 2022
When selecting replicas in a search, the coordinating node prefers nodes with the same shard allocation awareness attributes. If the search contains a custom preference string, then it will be ignored in favor of selecting a node with the same attributes. In 8.0, allocation awareness attributes no longer influence search replica selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x. Instead, we document the behavior as a 'warning' and mention a system property that can be used to disable the behavior.
jtibshirani
added a commit
that referenced
this pull request
Feb 14, 2022
When selecting replicas in a search, the coordinating node prefers nodes with the same shard allocation awareness attributes. If the search contains a custom preference string, then it will be ignored in favor of selecting a node with the same attributes. In 8.0, allocation awareness attributes no longer influence search replica selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x. Instead, we document the behavior as a 'warning' and mention a system property that can be used to disable the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting replicas in a search, the coordinating node prefers nodes with
the same shard allocation awareness attributes. So even if a search specifies
the same custom
preferencevalues, different coordinating nodes may route itdifferently because of their awareness attributes.
In 8.0, allocation awareness attributes no longer influence search replica
selection. So although this is a bug, we do not intend to fix it in 7.x or 6.x.
Instead, we document the behavior as a 'warning' and mention a system property
that can be used to disable the behavior.
Addresses #53054.