Skip to content

Remove irrelevant nodeHotThreads comment above nodeUsage method in ClusterAdminClient #83706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2022
Merged

Remove irrelevant nodeHotThreads comment above nodeUsage method in ClusterAdminClient #83706

merged 2 commits into from
Apr 1, 2022

Conversation

@mushao999
Copy link
Contributor

@mushao999 mushao999 commented Feb 9, 2022

This PR remove the irrelevant nodeHotThreads comment above nodeUsage mehotd which was introduce by #24169.

@elasticsearchmachine elasticsearchmachine added v8.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Feb 9, 2022
@pquentin pquentin added the :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. label Feb 14, 2022
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Feb 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 14, 2022

Pinging @elastic/es-distributed (Team:Distributed)

@pquentin pquentin added the >docs General docs changes label Feb 14, 2022
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Feb 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 14, 2022

Pinging @elastic/es-docs (Team:Docs)

@mushao999
Copy link
Contributor Author

mushao999 commented Mar 10, 2022

Pinging @pquentin, please help to find an assignee, thanks

@mushao999
Copy link
Contributor Author

mushao999 commented Mar 21, 2022

Pinging @colings86 @jaymode , please help to reivew this.

@mushao999 mushao999 mentioned this pull request Apr 1, 2022
Merged
DaveCTurner
DaveCTurner approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner self-assigned this Apr 1, 2022
@DaveCTurner
Copy link
Contributor

DaveCTurner commented Apr 1, 2022

@elasticmachine ok to test

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 1, 2022
@DaveCTurner
Copy link
Contributor

DaveCTurner commented Apr 1, 2022

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit e55776a into elastic:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

@DaveCTurner DaveCTurner

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mushao999 @elasticmachine @DaveCTurner @pquentin @elasticsearchmachine @salvatore-campagna