Skip to content

[ML] Fix submit after shutdown in process worker service #83645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2022
Merged

[ML] Fix submit after shutdown in process worker service #83645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ffcf7
Fix submit after shutdown
davidkyle Feb 8, 2022
9cd1f7f
Update docs/changelog/83645.yaml
davidkyle Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/83645.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 83645
summary: Fix submit after shutdown in process worker service
area: Machine Learning
type: bug
issues:
- 83633
1 change: 1 addition & 0 deletions ...ml/src/main/java/org/elasticsearch/xpack/ml/job/process/ProcessWorkerExecutorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public synchronized void execute(Runnable command) {
EsRejectedExecutionException rejected = new EsRejectedExecutionException(processName + " worker service has shutdown", true);
if (command instanceof AbstractRunnable runnable) {
runnable.onRejection(rejected);
return;
Copy link
Member

@benwtrent benwtrent Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 sneaky

} else {
throw rejected;
}
Expand Down